Skip to content

chore: allow for range of line numbers in line number system test#141

Merged
nolanmar511 merged 1 commit intogoogle:masterfrom
nolanmar511:line-check-text
Oct 22, 2020
Merged

chore: allow for range of line numbers in line number system test#141
nolanmar511 merged 1 commit intogoogle:masterfrom
nolanmar511:line-check-text

Conversation

@nolanmar511
Copy link
Copy Markdown
Contributor

@nolanmar511 nolanmar511 commented Oct 21, 2020

This change also logs the pprof output to make failures easier to debug.

@nolanmar511 nolanmar511 changed the title chore: check for range of line numbers in line number sustem test chore: allow for range of line numbers in line number system test Oct 21, 2020
@nolanmar511 nolanmar511 mentioned this pull request Oct 21, 2020
Merged
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 21, 2020

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #141     +/-   ##
=========================================
  Coverage   42.26%   42.26%             
=========================================
  Files          28       14     -14     
  Lines        4126     2063   -2063     
  Branches       84       42     -42     
=========================================
- Hits         1744      872    -872     
+ Misses       2346     1173   -1173     
+ Partials       36       18     -18
Impacted Files Coverage Δ
...dejs/pprof-nodejs/ts/src/heap-profiler-bindings.ts
...-nodejs/pprof-nodejs/ts/test/test-heap-profiler.ts
...f-nodejs/pprof-nodejs/ts/src/profile-serializer.ts
...s/pprof-nodejs/ts/src/sourcemapper/sourcemapper.ts
.../pprof-nodejs/pprof-nodejs/ts/src/time-profiler.ts
...prof-nodejs/pprof-nodejs/ts/src/profile-encoder.ts
.../pprof-nodejs/pprof-nodejs/ts/src/heap-profiler.ts
...-nodejs/pprof-nodejs/ts/test/profiles-for-tests.ts
...odejs/pprof-nodejs/ts/test/test-profile-encoder.ts
...-nodejs/pprof-nodejs/ts/test/test-time-profiler.ts
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4aa87b...aeb6c43. Read the comment docs.

macieksmuga
macieksmuga reviewed Oct 21, 2020
View reviewed changes
@nolanmar511 nolanmar511 merged commit 49f23d6 into google:master Oct 22, 2020
@nolanmar511 nolanmar511 deleted the line-check-text branch October 22, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macieksmuga macieksmuga macieksmuga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nolanmar511 @codecov-io @macieksmuga